Carla & Laneia #13

laneia · 2019-05-16T16:52:13Z

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	Based on what data was provided it became clear what columns needed to be added for each class and how they related to one another.
What would be the Big-O time complexity of your /customers & /movies endpoints? What does the time complexity depend on? Explain your reasoning.	The time complexity is O(n). Time complexity depends on the data structure and the amount of data in it. In this case, since /customers and /movies indexes all of the data, the time complexity is a direct function of how much data there is.
What is the Big-O time complexity of the `POST /rentals/check-in` endpoint? What does the time complexity depend on? Explain your reasoning.	The rentals/check-in method time complexity is O(log(n)). The time complexity depends on how long it takes to use find_by to locate the data corresponding to the customer_id and movie_id, which is essentially a binary search.
Describe a set of positive and negative test cases you implemented for a model.	In the customer model we have a positive validation test to ensure it requires the name field for a customer. A negative test case is making sure the customer is invalid without providing the name field.
Describe a set of positive and negative test cases you implemented for a controller.	In the customers controller we have a positive test case for returning all of the customers. There is a negative test case for returning an empty array if there are no customers.
How does your API respond when bad data is sent to it?	It responds with an error hash with a message related to the error cause.
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	We added an available? method to the rental model that takes in a movie_id as input. This made sense to add to the rental model because it checks to ensure a movie has enough available inventory to be checked out before a new rental can be created.
Do you have any recommendations on how we could improve this project for the next cohort?	Not really.
Link to Trello	N/A
Link to ERD	https://i.imgur.com/sdTcFOV.jpg

Customers

… movies-and-rentals

… customers

… database

CheezItMan · 2019-05-24T04:59:20Z

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits and good commit messages
Comprehension questions	Check
General
Business Logic in Models	Good business logic methods!
All required endpoints return expected JSON data	Check
Requests respond with appropriate HTTP Status Code	Check
Errors are reported	Check
Testing
Passes all Smoke Tests	Once routes are adjusted, yes
Model Tests - all relations, validations, and custom functions test positive & negative cases	Check
Controller Tests - URI parameters and data in the request body have positive & negative cases	Some missing test cases here. See my inline comments.
Overall	Your routes were a little off what was expected. Once fixed things worked well. You also had some areas to improve in controller testing. You did hit all the requirements for the project. Well done.

CheezItMan · 2019-05-24T04:46:52Z

app/controllers/rentals_controller.rb

+  end
+
+  def checkin
+    rental = Rental.find_by(movie_id: rental_params[:movie_id], customer_id: rental_params[:customer_id], status: "Checked Out")


This line is too long, instead break it up over several lines.

CheezItMan · 2019-05-24T04:50:17Z

app/models/movie.rb

+  validates :title, :overview, :release_date, presence: true
+  validates :inventory, :available_inventory, presence: true, numericality: {only_integer: true, greater_than_or_equal_to: 0}
+
+  def available_inventory


Good business logic method!

CheezItMan · 2019-05-24T04:50:42Z

app/models/rental.rb

+
+  validates :customer_id, :movie_id, :due_date, :checkout, :status, presence: true
+
+  def available?(movie_id)


CheezItMan · 2019-05-24T04:53:05Z

test/models/customer_test.rb

@@ -0,0 +1,28 @@
+require "test_helper"
+
+describe Customer do


No tests for relationships, minor

CheezItMan · 2019-05-24T04:55:08Z

test/controllers/customers_controller_test.rb

+    end
+  end
+
+  describe "routes" do


CheezItMan · 2019-05-24T04:55:38Z

test/controllers/movies_controller_test.rb

+      get movie_path(movies(:one).id)
+      body = JSON.parse(response.body)
+
+      expect(body.keys.sort).must_equal movie_fields


CheezItMan · 2019-05-24T04:56:40Z

test/controllers/rentals_controller_test.rb

+      }
+    }
+
+    it "can create a new rental provided valid data" do


What about if there are no available movies?

CheezItMan · 2019-05-24T04:57:37Z

test/controllers/rentals_controller_test.rb

+    end
+  end
+
+  describe "checkin" do


What about trying to check in a movie which isn't checked out?

laneia and others added 30 commits May 14, 2019 13:17

initial rails api setup

2feed61

Initial db setup

ffef6d6

generated controllers

b824647

added routes

c5cf416

Added validations for customer and movie

e2665db

Merge commit

2220ffa

added create valid rental test

62aaff3

fleshed out valid new rental test

12724c8

Added index to customer

002679c

added test for new rental w/ invalid customer id

0b28dc6

added test for new rental w/ invalid movie

be39749

added movies fixtures

fccbdaf

Added test to customer model

fbc7913

added movies index test 1

932e23f

added check for json and array in index test

56e0ba2

added response length = movie count check

70fa899

Added checked-out count column to customers table

424c415

added movie field test

eb87d6a

added movie sort tests

6a12ac9

added test for create movie w/ valid data

25e083b

added create movie test for invalid data

74b2b3c

Merge pull request #1 from laneia/customers

d157356

Customers

Merge branch 'master' of https://github.com/laneia/VideoStoreAPI into…

c5816d9

… movies-and-rentals

Added tests for json response in customer controller

0365f3f

Merge branch 'master' of https://github.com/laneia/VideoStoreAPI into…

9c8a7a2

… customers

added movies index method

80804e6

added movie show method and params

2c5c257

added create movie method

8bd03b3

edited variable name for consistency new_movie -> movie

7efcaad

all movies controller tests passing

df2c3c2

laneia and others added 28 commits May 15, 2019 13:56

got rental tests passing, updated fixtures for available_inventory

084788e

Changed rental fixtures, added rental validation test

99281be

merge commit

06fa9c7

fixed merge conflict

ef49e0d

merge commit

150fbc4

added available_inventory method to movie

7d24164

Merge branch 'master' of https://github.com/laneia/VideoStoreAPI

5cf8ac4

fixing test description for consistency

7195177

Added relations tests to rental

1709dbe

Merge branch 'master' of https://github.com/laneia/VideoStoreAPI

cfb912d

Removed unnecessary line from movies model test

771265d

added available_inventory test one

3aff11d

added new movie fixture with no rentals

047b2ff

added second available_inventory test for no rental

f331145

added available_inventory to movie show & test

45d7795

Changed available inventory default to inventory

b5e9f85

added available_inventory to movies index & test

f0ad8e9

merge commit

aacc695

Merge branch 'master' of https://github.com/laneia/VideoStoreAPI into…

3fa1bce

… database

added test and validations for movies model

08ab61a

Merge branch 'master' of https://github.com/laneia/VideoStoreAPI

12f399b

added integer validation tests

51518d8

added relationship tests to movie test

d64632e

test fixture cosistency

ac630b5

Added tests to customer model and controller

1625736

Merge branch 'master' of https://github.com/laneia/VideoStoreAPI

0ad2029

added rental validations and tests, relevant test fixtures

a173b16

Merge branch 'master' of https://github.com/laneia/VideoStoreAPI

7d4c882

CheezItMan reviewed May 24, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Carla & Laneia #13

Carla & Laneia #13

Uh oh!

laneia commented May 16, 2019

Uh oh!

CheezItMan commented May 24, 2019

Uh oh!

CheezItMan May 24, 2019

Uh oh!

CheezItMan May 24, 2019

Uh oh!

CheezItMan May 24, 2019

Uh oh!

CheezItMan May 24, 2019

Uh oh!

CheezItMan May 24, 2019

Uh oh!

CheezItMan May 24, 2019

Uh oh!

CheezItMan May 24, 2019

Uh oh!

CheezItMan May 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		validates :customer_id, :movie_id, :due_date, :checkout, :status, presence: true

		def available?(movie_id)

Carla & Laneia #13

Are you sure you want to change the base?

Carla & Laneia #13

Uh oh!

Conversation

laneia commented May 16, 2019

Video Store API

Comprehension Questions

Uh oh!

CheezItMan commented May 24, 2019

Video Store

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants