Sopheary & Nara #10
Open
Sopheary & Nara #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Video StoreWhat We're Looking For
|
| if movie | ||
| render json: movie.as_json(except: [:id,:created_at, :updated_at], :methods => [:available_inventory]), status: :ok | ||
| else | ||
| render json: { "errors": ["Movie was not found"]}, status: :not_found |
There was a problem hiding this comment.
I would probably break line 10 up across multiple lines.
| movie = Movie.find_by(id: rental_params[:movie_id]) | ||
| if movie | ||
| if movie.available_inventory > 0 | ||
| rental = Rental.new(rental_params.merge(checkout_date: Date.today, due_date: Date.today + 7)) |
There was a problem hiding this comment.
Would it be possible to encapsulate this business logic in a model method? Something like Rental.check_out(customer_id, movie_id) might be a good interface.
|
|
||
| def movies_checked_out_count | ||
| self.rentals.where(checkin_date: nil).count | ||
| end |
There was a problem hiding this comment.
I love that you made Customer#movies_checked_out_count and Movie#available_inventory methods instead of storing them in the database. That way there's no way to forget to update these values.
| it "renders status bad request" do | ||
| get movie_path(-1) | ||
| must_respond_with :not_found | ||
| end |
There was a problem hiding this comment.
Since you send back specific JSON in the error case, it would be good to check that here as well.
| body = JSON.parse(response.body) | ||
|
|
||
| expect(body).must_be_kind_of Hash | ||
| expect(body).must_include "errors" |
There was a problem hiding this comment.
I like that you verify error JSON here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video Store API
Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.
Comprehension Questions
POST /rentals/check-inendpoint? What does the time complexity depend on? Explain your reasoning.