Bugfix/atr 936 dev remove noise alerts for px1065#658
Open
Conversation
…thout a BQL field is in base DACs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the PX1065 analyzer to reduce noise alerts by modifying its behavior for DAC extensions and derived DACs. The analyzer now only reports missing BQL field errors when properties are overridden or redeclared, rather than reporting errors for all base properties without BQL fields.
Changes:
- Modified PX1065 analyzer logic to skip reporting diagnostics for base type properties in DAC extensions
- Updated test cases to reflect the new behavior with additional test scenarios
- Enhanced documentation to clarify the new diagnostic behavior
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| NoBqlFieldForDacFieldPropertyAnalyzer.cs | Updated analyzer logic to skip reporting PX1065 for base type properties and improved diagnostic property handling |
| NoBqlFieldForDacFieldAnalyzerFix.cs | Modified code fix registration check to be more explicit |
| NoBqlFieldForDacFieldPropertyTests.cs | Updated test expectations to match new diagnostic behavior |
| DacWithBqlFieldMissingInBaseDac.cs | Added test case for Amount property and updated to nullable types |
| DacWithBqlFieldMissingInBaseDac_Expected.cs | Added expected BQL field for Amount property |
| DacExtensionWithBqlFieldMissingInBaseDac.cs | Added test case for Amount property in extension |
| DacExtensionWithBqlFieldMissingInBaseDac_Expected.cs | Added expected BQL field for Amount property in extension |
| DacWithBqlFieldMissingInExternalBaseDac.cs | Added test case for Amount property with external base DAC |
| DacExtensionWithBqlFieldMissingInExternalBaseDac.cs | Added test case for Amount property in extension with external base DAC |
| BaseDacWithoutBqlField.cs | Added Amount property without BQL field for testing |
| PX1065.md | Updated documentation to clarify when PX1065 is reported for derived DACs and extensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...lyzers/StaticAnalysis/NoBqlFieldForDacFieldProperty/NoBqlFieldForDacFieldPropertyAnalyzer.cs
Show resolved
Hide resolved
SENya1990
added
enhancement
SENya1990
commented
Jan 27, 2026
| ## Diagnostic Description | ||
|
|
||
| Acumatica Framework requires that all DAC field properties have a corresponding BQL field (a public abstract class) in the DAC. A missing BQL field may cause runtime errors or unexpected behavior in numerous places in the application code of Acumatica ERP. | ||
| Acumatica Framework requires that all DAC field properties have a corresponding BQL field (a public abstract class) in the DAC. A missing BQL field may cause runtime errors or unexpected behavior |
… from the ISV support team
SENya1990
commented
Feb 1, 2026
|
|
||
| ## Diagnostic Description | ||
| Data view delegates should not start long-running operations. A data view delegate is designed to prepare a data set to display it in the UI. The result of the data view delegate is returned before the end of the long-running operation. | ||
| Data view delegates should not start long-running operations. A data view delegate is designed to prepare a data set to display it in the UI. If the results of the long-running operation are not awaited synchronously, |
Collaborator
Author
There was a problem hiding this comment.
@EAndrosova please review the updates in PX1080
dropsonic
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Overview