fix: remove deprecated keyboard option from vis-timeline#826
Conversation
vis-timeline v7 removed the `keyboard` configuration option that existed in the original vis.js library. Passing it triggers a console warning: Unknown option detected: "keyboard". Did you mean "end"? This also causes an error in the Raw Data view (see ActivityWatch/aw-server-rust#603). The `horizontalScroll` option is retained since it is still supported in vis-timeline v7.
Greptile SummaryRemoves the
Confidence Score: 5/5Safe to merge — removes a four-line option block that vis-timeline v7 already ignores, eliminating a spurious console warning with no change in runtime behaviour. The change is a strict removal of a configuration key that vis-timeline v7 no longer recognises. Because the library was already silently ignoring the block, no keyboard-navigation behaviour changes between the before and after states. The comment is also updated to stay accurate. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Vue as VisTimeline.vue
participant vt as vis-timeline v7
Note over Vue,vt: Before fix
Vue->>vt: "new Timeline(el, [], [], { horizontalScroll, keyboard: {...} })"
vt-->>Vue: ⚠️ Console warning: "Unknown option detected: keyboard"
Note over Vue,vt: After fix
Vue->>vt: "new Timeline(el, [], [], { horizontalScroll })"
vt-->>Vue: ✅ No warning, timeline initialises cleanly
Reviews (1): Last reviewed commit: "fix: remove deprecated keyboard option f..." | Re-trigger Greptile |
vis-timeline v7 dropped the
keyboardconfiguration option (it was part of the original vis.js library). Passing it triggers a console warning:This shows up as an error in the Raw Data view — reported in ActivityWatch/aw-server-rust#603.
The fix just removes the
keyboardblock fromVisTimeline.vueoptions.horizontalScrollis kept since it's still a valid vis-timeline v7 option.