build(deps): bump actions/upload-artifact from 4 to 6#732
Open
dependabot[bot] wants to merge 1 commit intomasterfrom
Open
build(deps): bump actions/upload-artifact from 4 to 6#732dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 6. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v6) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 2ca4182 in 39 seconds. Click for details.
- Reviewed
40lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/nodejs.yml:33
- Draft comment:
Update actions/upload-artifact from v4 to v6 in the build-webpack job. Ensure that self‐hosted runners (if used) have runner version ≥2.327.1 required by v6. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is related to a dependency update, specifically for a GitHub Action. It also includes a note about ensuring compatibility with self-hosted runners. According to the rules, comments on dependency changes or library versions should be ignored, especially if they are not recognized. This comment seems to fall under that category.
2. .github/workflows/nodejs.yml:61
- Draft comment:
Bump actions/upload-artifact in the build-vite job to v6. Verify that Node.js 24 support requirements are met. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is about bumping a dependency version and asking to verify Node.js support requirements. This falls under the rule of not commenting on pure dependency changes or asking the author to verify or ensure something.
3. .github/workflows/nodejs.yml:175
- Draft comment:
Upgrade the 'Upload screenshots' step from actions/upload-artifact@v4.3.6 to v6. Confirm behavior remains consistent with expectations. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is about upgrading a dependency version and asks the author to confirm behavior, which violates the rules. It doesn't provide a specific suggestion or point out a specific issue with the code.
4. .github/workflows/nodejs.yml:196
- Draft comment:
Update the 'Upload logs' step to actions/upload-artifact@v6. Ensure that log artifacts upload correctly with the new version. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to ensure that the log artifacts upload correctly with the new version of a dependency. This falls under the rule of not asking the author to ensure behavior is intended or tested. Therefore, this comment should be removed.
Workflow ID: wflow_M1ChmLrpVjAB9xI5
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/upload-artifact from 4 to 6.
Release notes
Sourced from actions/upload-artifact's releases.
... (truncated)
Commits
b7c566aMerge pull request #745 from actions/upload-artifact-v6-releasee516bc8docs: correct description of Node.js 24 support in READMEddc45eddocs: update README to correct action name for Node.js 24 support615b319chore: release v6.0.0 for Node.js 24 support017748bMerge pull request #744 from actions/fix-storage-blob38d4c79chore: rebuild dist7d27270chore: add missing license cache files for@actions/core,@actions/io, and mi...5f643d3chore: update license files for@actions/artifact@5.0.1 dependencies1df1684chore: update package-lock.json with@actions/artifact@5.0.1b5b1a91fix: update@actions/artifactto ^5.0.0 for Node.js 24 punycode fixYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Important
Bump
actions/upload-artifactfrom v4 to v6 innodejs.yml, requiring Node.js 24 and Actions Runner 2.327.1+.actions/upload-artifactfrom v4 to v6 innodejs.yml.build-webpack,build-vite,testjobs.This description was created by
for 2ca4182. You can customize this summary. It will automatically update as commits are pushed.