fix: missing bucket ID when editing events#644
Open
BelKed wants to merge 1 commit intoActivityWatch:masterfrom
Open
fix: missing bucket ID when editing events#644BelKed wants to merge 1 commit intoActivityWatch:masterfrom
BelKed wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 543393b in 54 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. src/visualizations/VisTimeline.vue:167
- Draft comment:
Good fix: bucketId is now directly retrieved from items, ensuring the correct bucket ID is used for API calls. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is purely informative, as it simply states what the code is doing without providing any suggestions, questions, or potential issues. It does not align with the rules for useful comments.
2. src/visualizations/VisTimeline.vue:167
- Draft comment:
Using the item’s 'group' property directly to retrieve the bucket ID is cleaner and avoids the pitfall of relying on group content—which can be empty if row labels are hidden. Confirm that the 'group' field in items always holds the correct bucket ID for $aw.getEvent(). - Reason this comment was not posted:
Comment looked like it was already resolved.
3. src/visualizations/VisTimeline.vue:170
- Draft comment:
Typo in comment: "ensure if's not cut-off by the query range" should likely be "ensure it's not cut off by the query range". - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_CHHOcBViI8bEGPS3
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #644 +/- ##
==========================================
+ Coverage 26.15% 26.76% +0.61%
==========================================
Files 28 28
Lines 1652 1655 +3
Branches 289 280 -9
==========================================
+ Hits 432 443 +11
- Misses 1161 1186 +25
+ Partials 59 26 -33 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Fixes only for Raw Data; Search and Query works a bit different :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to solve #576
Important
Fixes missing bucket ID when editing events in
VisTimeline.vueby correctingbucketIdassignment inonSelectmethod.onSelectmethod ofVisTimeline.vue.bucketIdassignment to usethis.items[properties.items[0]].groupinstead of searching throughgroups.This description was created by
for 543393b. It will automatically update as commits are pushed.