Open
Conversation
Contributor
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 589bec0 in 33 seconds
More details
- Looked at
139lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/client.js:95
- Draft comment:
Ensure thatdatais not used elsewhere in a way that could be affected by the modification ofpayload.datato include tags. - Reason this comment was not posted:
Confidence changes required:50%
ThesendHeartbeatfunction inclient.jsuseschrome.storage.local.getto retrieve tags, which is asynchronous. The rest of the function depends on this data, so it's correctly placed inside the callback. However, thepayloadobject is being modified directly, which is fine, but it's important to ensure thatdatais not used elsewhere in a way that could be affected by this modification.
Workflow ID: wflow_MB6euDjToBpyXjzI
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| let tagsInput = document.getElementById('status-tags-input'); | ||
| tagsInput.addEventListener("change", (event) => { | ||
| const tags = event.target.value.split(',').map(tag => tag.trim()).filter(tag => tag); | ||
| chrome.storage.local.set({ tags: event.target.value }); |
Contributor
There was a problem hiding this comment.
Store the processed array of tags instead of the raw input value to ensure consistency and avoid storing unnecessary spaces.
Suggested change
| chrome.storage.local.set({ tags: event.target.value }); | |
| chrome.storage.local.set({ tags: tags }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds tags field to extension popup and adds to payload sent to server


Important
Adds a 'tags' field to the extension popup and includes it in the server payload if available.
popup.htmlfor user input.sendHeartbeatinclient.jsto include 'tags' in the payload if they exist in local storage.popup.js: Retrieves and displays 'tags' from local storage in the input field.This description was created by
for 589bec0. It will automatically update as commits are pushed.