Lower default threshold for skipped failed choices to 0.1%#1063
Open
i-am-sijia wants to merge 2 commits intoActivitySim:mainfrom
Open
Lower default threshold for skipped failed choices to 0.1%#1063i-am-sijia wants to merge 2 commits intoActivitySim:mainfrom
i-am-sijia wants to merge 2 commits intoActivitySim:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request tightens the default allowed threshold for failed choices and clarifies documentation around the transition to
skip_failed_choices.fraction_of_failed_choices_allowedfrom 0.1 to 0.001, as discussed in Default setting for skipping households on simulation failure #1052 (comment), causing the model to fail with far fewer skipped households, andImpact on existing model runs:
With
skip_failed_choicesdefaulted toTrueand an allowed failure threshold as low as 0.1%, failures that were previously silently masked will now generate warnings, be explicitly skipped, and counted toward the threshold. As a result, model runs that previously completed "successfully" may now fail earlier, surfacing underlying specification or data issues that require attention rather than being silently absorbed. @jpn-- we may want to include this note in the next ActivitySim release note.