Truncate web.useragent sent to BankID in Auth/Sign/Payment API call. #531
+48
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if the value exceeds the max length of 256 characters.
Abrissirba
reviewed
Dec 18, 2025
Contributor
Abrissirba
left a comment
Abrissirba
left a comment
There was a problem hiding this comment.
Can we add a unit test for this
Abrissirba
approved these changes
Dec 18, 2025
elinohlsson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncate User-Agent to comply with BankID API limits
Problem
BankID enforces a maximum length on the
web.userAgentfield. If this limit is exceeded, BankID returns a400error and authentication fails. Some browsers and environments provide long User-Agent strings (for example, iOS in-app browsers such as Facebook or Instagram) that can exceed this limit.Solution
The built-in default implementation of
IBankIdEndUserDeviceDataResolver(BankIdDefaultEndUserWebDeviceDataResolver) now automatically truncates the User-Agent value to the maximum length allowed by the BankID API before sending it.Result
Authentication succeeds even when the client User-Agent exceeds BankID’s maximum length.
This PR relates to #530.