refactor and fix redirecturl to bankid #524
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Do we have an issue describing this change? What is the current behaviour? What breaking changes are we introducing with this change? |
elinohlsson
reviewed
Nov 7, 2025
| public bool CheckStatus { get; } | ||
| public string OrderRef { get; } | ||
| public string? RedirectUri { get; } | ||
| public string? LaunchUrl { get; } |
Contributor
There was a problem hiding this comment.
If this is renamed i also needs to be renamed in activelogin-main.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that for all same-device scenarios we send a RedirectUrl to BankId.
This sets the groundwork needed for sending a nonce included in the redirectUrl (which is strongly recommended).
Logic for constructing a valid RedirectUrl is found in BankIdRedirectUrl.
This needs extensive testing, the automated testing is not enough to ensure expected behavior. Using manual testing we can extend the tests based on our observations.