fix(#479): store uiOptions in cookie #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zonnex
force-pushed
the
fix/479-returnUrl
branch
from
82ed682 to
f332f67
Compare
elinohlsson
reviewed
Oct 9, 2025
src/ActiveLogin.Authentication.BankId.AspNetCore/Auth/BankIdAuthHandler.cs
Show resolved
Hide resolved
elinohlsson
reviewed
Oct 9, 2025
...gin.Authentication.BankId.AspNetCore/Areas/ActiveLogin/Controllers/BankIdUiControllerBase.cs
Outdated
Show resolved
Hide resolved
elinohlsson
reviewed
Oct 9, 2025
src/ActiveLogin.Authentication.BankId.AspNetCore/Cookies/BankIdUiOptionsCookieManager.cs
Outdated
Show resolved
Hide resolved
added 4 commits
October 9, 2025 13:32
Move constants to BankIdConstants file.
…d and not the protected ui options.
…us complete of failed from collect).
elinohlsson
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #516.
As per the issue linked, sometimes we send returnUrls to BankId that are invalid, one case seem to be that the returnUrl is too long which in our internal testing resulted in cryptic error, but others have received "Invalid Parameter". We couldn't replicate this directly but it's definitely a problem if the uiOptions are too long, which is also ugly.
Later we have a solution for those who wish to store data somewhere else but to fix issue we went with this approach for now, that we store the UIOptions in a cookie and pass a guid in the returnUrl instead. I have not had time to test this thoroughly so that's remaining.