Skip to content

Update zh-cn.json and zh-hant.json#1969

Open
LaunchLee wants to merge 1 commit intoAcode-Foundation:mainfrom
LaunchLee:Patch-CN
Open

Update zh-cn.json and zh-hant.json#1969
LaunchLee wants to merge 1 commit intoAcode-Foundation:mainfrom
LaunchLee:Patch-CN

Conversation

@LaunchLee
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the translations Anything related to Translations Whether a Issue or PR label Mar 20, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 20, 2026

Greptile Summary

This PR adds Simplified Chinese (zh-cn.json) and Traditional Chinese (zh-hant.json) translations for 205 entries that were previously left in English, covering new LSP (Language Server Protocol) UI strings, settings category labels, and settings description text introduced in a recent feature update.

Key observations:

  • All interpolation placeholders ({details}, {feature}, {state}, {version}, {timeout}, {server}, {status}, {method}) are correctly preserved in every translated string in both files.
  • JSON syntax is valid — the curly/typographic quotes (" / ", U+201C/U+201D) used around 添加 in zh-cn.json are distinct from ASCII " and do not require escaping.
  • The "search result label singular" and "search result label plural" entries both map to "条结果" / "條結果" — this is correct since Chinese has no grammatical plural distinction.
  • The "lsp-feature-state-toast" template is adapted from "{feature} {state}" to "{feature} 已{state}", which is idiomatic Chinese and pairs correctly with the lsp-state-enabled / lsp-state-disabled values.
  • One minor issue: "settings-note-lsp-settings" omits the final sentence "Managed installers run inside the terminal/proot environment." from both locale files.

Confidence Score: 5/5

  • This PR is safe to merge — it only touches locale JSON files with no runtime logic changes.
  • All 205 translated entries are structurally correct, JSON is valid, and all template variables are intact. The only finding is a minor omission of one informational sentence in a settings note, which does not affect functionality.
  • No files require special attention beyond the noted omission in the settings-note-lsp-settings key.

Important Files Changed

Filename Overview
src/lang/zh-cn.json Translates 205 previously-English entries to Simplified Chinese; all template placeholders ({details}, {feature}, {state}, {version}, {timeout}, etc.) are preserved correctly, JSON syntax is valid (curly quotes U+201C/U+201D used around 添加 are not bare ASCII quotes), but the last sentence of settings-note-lsp-settings is omitted.
src/lang/zh-hant.json Translates the same 205 entries to Traditional Chinese; uses appropriate Traditional characters and corner-bracket quotation marks (「」); all placeholders preserved; same minor omission in settings-note-lsp-settings as zh-cn.json.

Sequence Diagram

sequenceDiagram
    participant App as Acode App
    participant I18N as i18n Module
    participant ZhCN as zh-cn.json
    participant ZhHant as zh-hant.json

    App->>I18N: Request translation key (e.g. "lsp-feature-completion")
    I18N->>ZhCN: Lookup key (if locale = zh-cn)
    ZhCN-->>I18N: "代码补全"
    I18N->>ZhHant: Lookup key (if locale = zh-hant)
    ZhHant-->>I18N: "代碼補全"
    I18N-->>App: Translated string

    Note over App,ZhHant: Template interpolation example
    App->>I18N: "lsp-feature-state-toast" with {feature="代码补全", state="启用"}
    I18N->>ZhCN: Lookup "{feature} 已{state}"
    ZhCN-->>I18N: "代码补全 已启用"
    I18N-->>App: Rendered toast message
Loading

Last reviewed commit: "Update zh-cn.json an..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translations Anything related to Translations Whether a Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant