Open
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
bajrangCoder
approved these changes
Feb 16, 2026
Member
bajrangCoder
left a comment
There was a problem hiding this comment.
LGTM!
But make sure to update plugin docs and api packages accordingly (also plugin template if needed)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Cordova plugin (pluginContext) that implements token-based access control for Acode plugins. Each plugin receives a unique UUID token associated with permissions declared in their plugin.json file, enabling runtime permission verification.
Changes:
- Created a new Cordova plugin with JavaScript and Android implementations for token-based permission management
- Integrated the plugin into the existing plugin loading system to provide context objects to plugins
- Added plugin configuration files and registered the new plugin in the main package.json
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugins/pluginContext/www/PluginContext.js | JavaScript module providing the PluginContext API with token generation and permission checking methods |
| src/plugins/pluginContext/src/android/Tee.java | Android implementation managing token lifecycle, permission storage, and validation |
| src/plugins/pluginContext/plugin.xml | Cordova plugin configuration defining the plugin structure and platform bindings |
| src/plugins/pluginContext/package.json | NPM package metadata for the pluginContext Cordova plugin |
| src/lib/loadPlugin.js | Integration point adding context object generation during plugin initialization |
| package.json | Registration of the new plugin in the project's Cordova dependencies |
| .prettierrc | Added empty Prettier configuration file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
UnschooledGamer
approved these changes
Feb 16, 2026
Member
|
Also, JSON Plugin Schema needs updation for this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new Cordova plugin (pluginContext) that provides token-based access control for Acode plugins. Each plugin receives a unique UUID token tied to declared permissions from plugin.json, enabling runtime permission checks via ctx.grantedPermission() and ctx.listAllPermissions().