[bug fix] Move "depth is None" warning from StorageAttributes.__init__ to Storage.__init__#44
Open
Polarisyjr wants to merge 1 commit intoAccelergy-Project:mainfrom
Conversation
StorageAttributes does not have a `name` attribute (it inherits from Attributes/DictNode, not Leaf). Move the depth warning to Storage.__init__ where both `self.name` and `self.attributes.depth` are accessible.
Polarisyjr
changed the title
Polarisyjr
changed the title
Polarisyjr
changed the title
StorageAttributes.__init__ to Storage.__init__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The depth warning in
StorageAttributes.__init__referencesself.name, butStorageAttributesinherits fromAttributes/DictNodeand does not have a name attribute, causing a potentialAttributeError.Fix: Move the warning to
Storage.__init__, which inherits fromComponent→Leaf, whereself.nameis properly defined.