Use installed pybind11 and other CMake fixes#2009
Use installed pybind11 and other CMake fixes#2009jfpanisset wants to merge 6 commits intoAcademySoftwareFoundation:mainfrom
Conversation
- Adds OTIO_FIND_PYBIND11 configuration option to tell CMake to look for a pre-installed pybind11 instead of using the vendored copy. Follows existing pattern for Imath and rapidjson dependencies. [Issue AcademySoftwareFoundation#2006](AcademySoftwareFoundation#2006). - A couple of bugfixes in src/deps/CMakeLists.txt - checking for empty submodule directories was broken - rapidjson subdmodule would not get built - Generated CMake files get installed in /usr/local/lib/cmake/opentime and opentimelineio instead of /usr/local/share/opentime and opentimelineio which is what the CMake documentation suggests. [Issue AcademySoftwareFoundation#2008](AcademySoftwareFoundation#2008). Signed-off-by: Jean-Francois Panisset <panisset@gmail.com>
|
Hmm, wasn't expecting this to break the build so badly. Converted PR to draft, looking into it. |
|
For this failed build: the error is: The I see that my changes are actually trying to build the |
rapidjson as a submodule won't build in our environment due to old CMake version requirements, and since it's a header-only library, we only need the headers to be present to allow opentimelineio to build. Signed-off-by: Jean-Francois Panisset <panisset@gmail.com>
Signed-off-by: Jean-Francois Panisset <panisset@gmail.com>
Signed-off-by: Jean-Francois Panisset <panisset@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2009 +/- ##
=======================================
Coverage 85.14% 85.14%
=======================================
Files 181 181
Lines 12780 12780
Branches 1206 1206
=======================================
Hits 10882 10882
Misses 1715 1715
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Address PR feedback: better explanation of why we don't try to build the rapidjson dependency. Signed-off-by: Jean-Francois Panisset <panisset@gmail.com>
Signed-off-by: Jean-Francois Panisset <panisset@gmail.com>
Adds OTIO_FIND_PYBIND11 configuration option to tell CMake to look for a pre-installed pybind11 instead of using the vendored copy. Follows existing pattern for Imath and rapidjson dependencies.
Fixes #2006.
Bugfixes in src/deps/CMakeLists.txt
Generated CMake files now installed in
lib/cmake/opentimeandlib/cmake/opentimelineioinstead of
share/opentimeandshare/opentimelineioas per CMake documentation.Fixes #2008.