fix: SG-43096: Fix Playback buttons offset displacement

[deltag0]

fix: Fix Bottom Toolbar offset displacement

Summarize your change.

Changed toolbar UI to be designed in 3 boxes:

• left box
• center box
• right box
  instead of adding the components individually to the toolbar.

Describe the reason for the change.

Easier to position different areas of the toolbar, and no problem with offsets with new components to the toolbar nor positioning existing components.
Because the QT actions aren't added directly to the toolbar, a separate overflow function had to be created, and buttons created by plugins had new functions added to manage them.

Describe what you have tested and on which operating system.

• Tested that toolbar functionality works the same
• Tested that the playback buttons don't get displaced
• Tested the fix on layout mode

Add a list of changes, and note any that might need special attention during the review.

• Toolbar button overflow when resizing the window
• Toolbar buttons with pictures loaded and without
• When resizing the window, the button overflow behaviour is slightly different. Now, the Play/Resume buttons will always remain visible in the application

If possible, provide screenshots.

[eloisebrosseau]

This line is duplicated in RVBottomViewToolBar.cpp

[deltag0]

fixed

[eloisebrosseau]

You should avoid using c-style arrays and use std::array instead

[deltag0]

fixed

[bernie-laberge]

Since that they are only used in this inline method (insert_before_play_mode), I would move play_mode_btn and right_layout in it:

        def insert_before_play_mode(widget):
            play_mode_btn = right_box.findChild(QtWidgets.QToolButton, "playModeButton")
            right_layout = right_box.layout()
            right_layout.insertWidget(right_layout.indexOf(play_mode_btn), widget)

[bernie-laberge]

I guess we don't want to keep that right ? (It was just for your own debugging correct?)

[bernie-laberge]

I like the way the new bottom toolbar implementation behaves, and I was able to validate that it solves the original issue. I would have preferred a more limited blast radius for this change, but I also appreciate the code cleanup. Now my only concern is that this refactoring could potentially break some third-party UI customization. FYI: The RV toolbars are customizable by the users: qtutils.sessionBottomToolBar() (https://aswf-openrv.readthedocs.io/en/latest/rv-manuals/rv-reference-manual/rv-reference-manual-chapter-four.html#pyside-example)
Let's publish an RV 2026 pre-release with it asap once it has been tested and merged, so that we get some feedback from the RV or from the Open RV community.
Thanks for the fix @deltag0 !

[bernie-laberge]

I like the way the new bottom toolbar implementation behaves, and I was able to validate that it solves the original issue. I would have preferred a more limited blast radius for this change, but I also appreciate the code cleanup. Now my only concern is that this refactoring could potentially break some third-party UI customization. FYI: The RV toolbars are customizable by the users: qtutils.sessionBottomToolBar() (https://aswf-openrv.readthedocs.io/en/latest/rv-manuals/rv-reference-manual/rv-reference-manual-chapter-four.html#pyside-example)
Let's publish an RV 2026 pre-release with it asap once it has been tested and merged, so that we get some feedback from the RV or from the Open RV community.
Thanks for the fix @deltag0 !