chore: SG-43295: hide noisy build log warnings#1175
Conversation
…no-cast-function-type-mismatch (GCC/Clang) -Wno-deprecated-declarations (GCC/Clang) /wd4996 (MSVC equivalent for deprecated declarations) Signed-off-by: Michael Oliver <mcoliver@gmail.com>
…ve 10% (12,000) log lines. Signed-off-by: Michael Oliver <mcoliver@gmail.com>
bernie-laberge
left a comment
There was a problem hiding this comment.
LGTM
Thank you @mcoliver !
|
Hi @mcoliver! I agree there is a lot of noise when building Open RV. However, I don't think we should suppress the warnings instead of actually fixing the underlying issues in our own code. I think we should only mute warnings coming from third-parties since we don't have any control over them. Would you mind only keeping that part? Also, note that I believe |
|
@eloisebrosseau I don't disagree. Would love to fix them as well. I was noticing that a lot of the warnings are due to out of date dependencies (old versions of Qt, pyside, etc..) and my understanding is that this project is hamstrung in modernizing those things by being beholden to the vfx reference platform maximum version requirements and support of various CY years. |
@mcoliver I totally understand where you're coming from, and it's true that the VFX Reference Platform prevents us from modernizing some dependencies, but I also know that some of these warnings are coming from issues in our own code that we could fix. I know it's more work to silence the warnings per dependency, but I feel this would be more appropriate to specifically know what we are silencing instead of acting like our code doesn't have all these warnings by ignoring them. |
Local build logs are incredibly noisy and often surpass 100,000 lines. Hiding these two specific warnings cleans up over 10% of the log lines. Pyside6 builds alone produce over 12,000 lines of these warnings
Adding
Linked issues
Summarize your change.
Describe the reason for the change.
Describe what you have tested and on which operating system.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.