Skip to content

chore: SG-43295: hide noisy build log warnings#1175

Open
mcoliver wants to merge 3 commits into
AcademySoftwareFoundation:mainfrom
mcoliver:build-warning-supression
Open

chore: SG-43295: hide noisy build log warnings#1175
mcoliver wants to merge 3 commits into
AcademySoftwareFoundation:mainfrom
mcoliver:build-warning-supression

Conversation

@mcoliver
Copy link
Copy Markdown
Contributor

@mcoliver mcoliver commented Mar 3, 2026

Local build logs are incredibly noisy and often surpass 100,000 lines. Hiding these two specific warnings cleans up over 10% of the log lines. Pyside6 builds alone produce over 12,000 lines of these warnings

/Users/moliver/dev/_openrv/OpenRV/_build/_deps/rv_deps_pyside6-src/build/.venv/build/pyside6/PySide6/QtCore/PySide6/QtCore/qtimer_wrapper.cpp:1198:18: warning: cast from 'PyObject *(*)(PyObject *)' (aka '_object *(*)(_object *)') to 'PyCFunction' (aka '_object *(*)(_object *, _object *)') converts to incompatible function type [-Wcast-function-type-mismatch]
 1198 |     {"interval", reinterpret_cast<PyCFunction>(Sbk_QTimerFunc_interval), METH_NOARGS, nullptr},
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 

Adding

…no-cast-function-type-mismatch (GCC/Clang)
-Wno-deprecated-declarations (GCC/Clang)
/wd4996 (MSVC equivalent for deprecated declarations)

Linked issues

Summarize your change.

Describe the reason for the change.

Describe what you have tested and on which operating system.

Add a list of changes, and note any that might need special attention during the review.

If possible, provide screenshots.

mcoliver added 2 commits March 3, 2026 10:01
…no-cast-function-type-mismatch (GCC/Clang)

-Wno-deprecated-declarations (GCC/Clang)
/wd4996 (MSVC equivalent for deprecated declarations)
Signed-off-by: Michael Oliver <mcoliver@gmail.com>
…ve 10% (12,000) log lines.

Signed-off-by: Michael Oliver <mcoliver@gmail.com>
@mcoliver mcoliver changed the title clean up 90% of build log warnings which are quite noisy by adding -W… chore: hide noisy build log warnings Mar 3, 2026
@mcoliver mcoliver marked this pull request as ready for review March 3, 2026 19:18
@bernie-laberge bernie-laberge changed the title chore: hide noisy build log warnings chore: SG-43295: hide noisy build log warnings May 12, 2026
@bernie-laberge bernie-laberge added the PR: Acknowledged New PR has been acknowledge by the TSC label May 12, 2026
Copy link
Copy Markdown
Contributor

@bernie-laberge bernie-laberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @mcoliver !

@bernie-laberge bernie-laberge added PR: Planned_P2 The PR will be review and test eventually, expect 1 to 3 months delay. community Contribution from the Open RV Community and removed PR: Acknowledged New PR has been acknowledge by the TSC labels May 12, 2026
@eloisebrosseau
Copy link
Copy Markdown
Contributor

Hi @mcoliver! I agree there is a lot of noise when building Open RV. However, I don't think we should suppress the warnings instead of actually fixing the underlying issues in our own code. I think we should only mute warnings coming from third-parties since we don't have any control over them. Would you mind only keeping that part? Also, note that I believe -Wno-cast-function-type-mismatch only exists for Clang, not GNU, so that might cause other kinds of warnings.

@mcoliver
Copy link
Copy Markdown
Contributor Author

@eloisebrosseau I don't disagree. Would love to fix them as well. I was noticing that a lot of the warnings are due to out of date dependencies (old versions of Qt, pyside, etc..) and my understanding is that this project is hamstrung in modernizing those things by being beholden to the vfx reference platform maximum version requirements and support of various CY years.

@eloisebrosseau
Copy link
Copy Markdown
Contributor

@eloisebrosseau I don't disagree. Would love to fix them as well. I was noticing that a lot of the warnings are due to out of date dependencies (old versions of Qt, pyside, etc..) and my understanding is that this project is hamstrung in modernizing those things by being beholden to the vfx reference platform maximum version requirements and support of various CY years.

@mcoliver I totally understand where you're coming from, and it's true that the VFX Reference Platform prevents us from modernizing some dependencies, but I also know that some of these warnings are coming from issues in our own code that we could fix. I know it's more work to silence the warnings per dependency, but I feel this would be more appropriate to specifically know what we are silencing instead of acting like our code doesn't have all these warnings by ignoring them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Contribution from the Open RV Community PR: Planned_P2 The PR will be review and test eventually, expect 1 to 3 months delay.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants