chore: SG-43312: spdlog 1.11.0 -> 1.17.0#1170
Open
mcoliver wants to merge 4 commits into
Open
Conversation
bug fixes, security fixes, and feature improvements https://github.com/gabime/spdlog/releases gabime/spdlog@v1.11.0...v1.17.0 Signed-off-by: Michael Oliver <mcoliver@gmail.com>
Windows builds failing on spdlog and oiio because they bundle fmt which requires a utf-8 flag when compiling on windows. Error was D:\a\OpenRV\OpenRV\_build\RV_DEPS_SPDLOG\install\include\spdlog\fmt\bundled\base.h(465,28): error C2338: static_assert failed: 'Unicode support requires compiling with /utf-8' [D:\a\OpenRV\OpenRV\_build\src\lib\base\TwkUtil\TwkUtil.vcxproj] Signed-off-by: Michael Oliver <mcoliver@gmail.com>
format fixes Signed-off-by: Michael Oliver <mcoliver@gmail.com>
mcoliver
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
Signed-off-by: Michael Oliver <mcoliver@gmail.com>
bernie-laberge
added
community
bernie-laberge
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Summarize your change.
Describe the reason for the change.
Describe what you have tested and on which operating system.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.