Adsk Contrib - Miscellaneous improvements suggested by Claude#2308
Open
doug-walker wants to merge 7 commits intoAcademySoftwareFoundation:mainfrom
Open
Adsk Contrib - Miscellaneous improvements suggested by Claude#2308doug-walker wants to merge 7 commits intoAcademySoftwareFoundation:mainfrom
doug-walker wants to merge 7 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used Claude Code (Sonnet 4.6) to review most of the core library. It found a number of bugs and minor issues such as pointers not being checked before use or memory allocations not being thoroughly validated. The only item that I would describe as a major bug was an issue that caused the inverse video shader for the GradingPrimaryTransform to not compile, which happened to be hidden by a flaw in one of the unit tests. The rest of it is a large collection of minor fixes to improve library robustness.