fix(propms): align lease sales order dates before insert#49
Open
Emmafidelis wants to merge 1 commit intoAakvatech-Limited:version-15from
Open
fix(propms): align lease sales order dates before insert#49Emmafidelis wants to merge 1 commit intoAakvatech-Limited:version-15from
Emmafidelis wants to merge 1 commit intoAakvatech-Limited:version-15from
Conversation
Lease-generated Sales Orders were using the generic insert-then-save flow, which let ERPNext validate backdated schedules before the order dates were aligned with the lease period. This caused due date validation errors when the payment schedule date fell before the effective Sales Order date. Update the Sales Order path to set the order date fields from the lease schedule before insert, keep delivery date aligned to the lease end of the billed period, and preserve the existing invoice flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lease-generated Sales Orders were using the generic insert-then-save flow, which let ERPNext validate backdated schedules before the order dates were aligned with the lease period. This caused due date validation errors when the payment schedule date fell before the effective Sales Order date.
Update the Sales Order path to set the order date fields from the lease schedule before insert, keep delivery date aligned to the lease end of the billed period, and preserve the existing invoice flow