Skip to content

Bugfix: critical error in max_event attr of detector file #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gwm17 merged 1 commit into from
Mar 31, 2025
Merged

Bugfix: critical error in max_event attr of detector file #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/attpc_engine/detector/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ def __init__(
self.max_events_per_file: int = max_events_per_file
self.run_number = first_run_number
self.starting_event = 0 # Kinematics generator always starts with event 0
self.last_event = 0 # What event number do we end on
self.events_written = 0 # haven't written anything yet
# initialize the first file
path: Path = self.directory_path / f"run_{self.run_number:04d}.h5"
Expand Down Expand Up @@ -250,6 +251,7 @@ def write(
_ = self.cloud_group.create_dataset(f"labels_{event_number}", data=labels)

# We wrote an event
self.last_event = event_number
self.events_written += 1

def set_number_of_events(self) -> None:
Expand All @@ -258,9 +260,7 @@ def set_number_of_events(self) -> None:
Stores first and last event numbers in the attributes
"""
self.cloud_group.attrs["min_event"] = self.starting_event
self.cloud_group.attrs["max_event"] = (
self.starting_event + self.events_written - 1
) # starting event counts towards number written
self.cloud_group.attrs["max_event"] = self.last_event

def get_directory_name(self) -> Path:
"""Returns directory that point cloud files are written to.
Expand Down