Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
您好，at-ui很小巧，我使用了她作为一个小项目的ui框架。
使用过程中，rate组件在disable属性为true时，整数会渲染成半星。
比如10分会渲染成4.5星。
根据逻辑，如果直接判断值是否为半星，在disable=false的情况下，页面不能选择半星：
const isHalf = this.value > Math.floor(this.value)
所以在这个情况下，我做了判断，在disable的情况时，在方法局部判断是否为半星：
const isHalf = this.disabled ? (this.value > Math.floor(this.value)) : this.isHalf