fix(ci): create tag before git-cliff in workflow_dispatch releases#47
Merged
jdsika merged 1 commit intoApr 23, 2026
Merged
Conversation
When the release workflow is triggered via workflow_dispatch, the target tag does not yet exist in git history. git-cliff --latest picks up the previous tag instead of generating notes for the new release. Fix: create a lightweight local tag before running git-cliff so --latest resolves to the correct range. Also removes continue-on-error from the changelog step so failures are surfaced instead of silently swallowed. Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de>
jdsika
changed the base branch from
main
to
fix/credential-status-did-compliance
jdsika
merged commit f2c12da
into
fix/credential-status-did-compliance
17 checks passed
jdsika
added a commit
that referenced
this pull request
May 7, 2026
* fix(examples)!: migrate credentialStatus to DID-based CRSet model BREAKING CHANGE: credentialStatus entries use the new statusServiceOperator + statusIndex model instead of the old non-compliant DID path id notation. - Migrate all 5 SimpulseID credential examples to new format - Update test_examples_integrity.py: check statusServiceOperator and statusIndex - Update docs/credentials/index.md credential skeleton - Pin harbour-credentials submodule to fix/credential-status-did-compliance Refs: reachhaven/harbour-credentials#6 Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de> * fix(ci): create tag before git-cliff in workflow_dispatch releases (#47) When the release workflow is triggered via workflow_dispatch, the target tag does not yet exist in git history. git-cliff --latest picks up the previous tag instead of generating notes for the new release. Fix: create a lightweight local tag before running git-cliff so --latest resolves to the correct range. Also removes continue-on-error from the changelog step so failures are surfaced instead of silently swallowed. Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de> * chore(deps): pin harbour-credentials submodule to v1.1.0 release The PR previously pinned to a feature branch commit (dd572d6) on fix/credential-status-did-compliance. Update to the v1.1.0 release tag (b89ddae) which includes the same CRSet model fix via squash-merge, plus CI improvements and the TypeScript pipeline. Refs: reachhaven/harbour-credentials#6 Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de> --------- Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port the release changelog fix from harbour-credentials to simpulse-id-credentials.
Changes
cd-release.ymlbefore the git-cliff actioncontinue-on-error: truefrom the changelog step so failures are visibleContext
When the release workflow is triggered via
workflow_dispatch, the target tag does not yet exist in git history.git-cliff --latestthen picks up the previous tag and generates an incorrect changelog (or fails silently due tocontinue-on-error).This is the same bug that was fixed in harbour-credentials (
2c73d30).Testing
workflow_dispatchtrigger creates lightweight tag before changelog generationRelated
2c73d30(fix(ci): create tag before git-cliff in workflow_dispatch releases)