fix(examples)!: migrate credentialStatus to DID-based CRSet model#46
Merged
Conversation
BREAKING CHANGE: credentialStatus entries use the new statusServiceOperator + statusIndex model instead of the old non-compliant DID path id notation. - Migrate all 5 SimpulseID credential examples to new format - Update test_examples_integrity.py: check statusServiceOperator and statusIndex - Update docs/credentials/index.md credential skeleton - Pin harbour-credentials submodule to fix/credential-status-did-compliance Refs: reachhaven/harbour-credentials#6 Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de>
When the release workflow is triggered via workflow_dispatch, the target tag does not yet exist in git history. git-cliff --latest picks up the previous tag instead of generating notes for the new release. Fix: create a lightweight local tag before running git-cliff so --latest resolves to the correct range. Also removes continue-on-error from the changelog step so failures are surfaced instead of silently swallowed. Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de>
The PR previously pinned to a feature branch commit (dd572d6) on fix/credential-status-did-compliance. Update to the v1.1.0 release tag (b89ddae) which includes the same CRSet model fix via squash-merge, plus CI improvements and the TypeScript pipeline. Refs: reachhaven/harbour-credentials#6 Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all SimpulseID credential examples and tests to the new DID-compliant
credentialStatusmodel introduced in harbour-credentials.Depends on: reachhaven/harbour-credentials PR (fix/credential-status-did-compliance)
Related: reachhaven/harbour-credentials#6
Changes
Examples (5 files)
All SimpulseID credentials migrated from:
To:
Affected files:
simpulseid-administrator-credential.jsonsimpulseid-ascs-base-membership-credential.jsonsimpulseid-ascs-envited-membership-credential.jsonsimpulseid-participant-credential.jsonsimpulseid-user-credential.jsonTests
test_credential_status_registry_resolvesupdated: now checksstatusServiceOperatorequals the revocation registry DID andstatusIndexis present (instead of checking oldidprefix)Documentation
docs/credentials/index.mdcredential skeleton updated with new fieldsSubmodule Pin
fix/credential-status-did-compliancebranchTesting
make test simpulseid— 182 tests, 149 passed, 0 failed (remaining are slow SHACL mutation tests — all credential-related tests green)test_credential_status_registry_resolvesBreaking Change
Same breaking change as harbour-credentials: consumers parsing
credentialStatus[].idmust update to readstatusServiceOperatorandstatusIndex.