Fix discord link #536
Fix discord link #536
Conversation
src/pages/projects.jsx to make the link display inline with the icon and text aligned correctly.
Signed-off-by: Mangesh Pagare <mangeshpagare8668@gmail.com>
|
@PAGARE-MANGESH is attempting to deploy a commit to the AOSSIE Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe changes update social links and branding across the codebase: Discord invite URLs are migrated to a new server, Twitter icon imports are swapped to X branding, FontAwesome dependencies are upgraded to newer versions, and project card links are refactored for improved accessibility by wrapping them in anchor elements with updated hover styling. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi maintainers 👋 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@package.json`:
- Around line 17-21: The package `@fortawesome/fontawesome-svg-core` is pinned to
6.2.1 but `@fortawesome/free-brands-svg-icons` is 7.1.0; update
`@fortawesome/fontawesome-svg-core` to a v7 range (e.g., ^7.0.0 or ^7.1.0) and
align the other FontAwesome packages (e.g., `@fortawesome/free-regular-svg-icons`,
`@fortawesome/free-solid-svg-icons`, `@fortawesome/react-fontawesome`) to compatible
v7 releases so all fontawesome packages use the same major version; after
updating the package.json entry names (e.g.,
"@fortawesome/fontawesome-svg-core": "^7.x"), run your package manager install
to refresh lockfiles and test for runtime/import issues.
🧹 Nitpick comments (2)
src/components/Footer.jsx (1)
48-49: Consider updating the aria-label to match the X branding.The icon is now
faXTwitter(X branding), but thearia-labelstill says "Follow on Twitter". For consistency and clarity for screen reader users, consider updating it to "Follow on X" or "Follow on X (Twitter)".💡 Suggested fix
- <Link aria-label="Follow on Twitter" className=' text-zinc-400 hover:text-[`#00843D`] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='https://twitter.com/aossie_org'> + <Link aria-label="Follow on X" className=' text-zinc-400 hover:text-[`#00843D`] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='https://twitter.com/aossie_org'>src/pages/index.jsx (1)
91-96: Consider updating the aria-label to match the X branding.Same as in
Footer.jsx- thearia-labelon line 92 says "Follow on Twitter" while the icon is nowfaXTwitter. Consider updating for consistency.💡 Suggested fix
<Link - aria-label="Follow on Twitter" + aria-label="Follow on X" className="text-zinc-500 transition hover:text-[`#00843D`] dark:text-zinc-400 dark:hover:text-yellow-400" href="https://twitter.com/aossie_org" > <FontAwesomeIcon icon={faXTwitter} size="2xl" /> </Link>
| "@fortawesome/fontawesome-svg-core": "^6.2.1", | ||
| "@fortawesome/free-brands-svg-icons": "^6.2.1", | ||
| "@fortawesome/free-brands-svg-icons": "^7.1.0", | ||
| "@fortawesome/free-regular-svg-icons": "^6.2.1", | ||
| "@fortawesome/free-solid-svg-icons": "^6.2.1", | ||
| "@fortawesome/react-fontawesome": "^0.2.0", | ||
| "@fortawesome/react-fontawesome": "^3.1.1", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
FontAwesome 7.1.0 free-brands-svg-icons compatibility fontawesome-svg-core 6
💡 Result:
Short answer: No — @fortawesome/free-brands-svg-icons@7.1.0 is part of Font Awesome v7 and expects the v7 SVG core; it is not intended to be used with @fortawesome/fontawesome-svg-core v6. Upgrade your fontawesome-svg-core to v7 to match the icon package. [1][2]
Sources:
- Font Awesome v7 upgrade / package docs. [1]
@fortawesome/free-brands-svg-iconspackage listing (v7.x). [2]
🌐 Web query:
react-fontawesome 3.1.1 peer dependencies fontawesome-svg-core version
💡 Result:
@fortawesome/react-fontawesome v3.1.1 lists @fortawesome/fontawesome-svg-core as a peer dependency; the package is compatible with Font Awesome core v6 (and v7 per the repo compatibility notes) — common peer-range seen is "~1 || ~6" (i.e. v6.x is supported). [1][2]
Sources:
- package info showing peerDependencies (jsDocs/npm metadata). [1]
- GitHub compatibility notes (react-fontawesome v3.x supports FontAwesome core 6.x and 7.x). [2]
Upgrade @fortawesome/fontawesome-svg-core to v7 to match @fortawesome/free-brands-svg-icons@7.1.0.
@fortawesome/free-brands-svg-icons@7.1.0 requires @fortawesome/fontawesome-svg-core v7, but the current version is 6.2.1. This incompatibility will cause runtime issues. Align all FontAwesome packages to v7.
🤖 Prompt for AI Agents
In `@package.json` around lines 17 - 21, The package
`@fortawesome/fontawesome-svg-core` is pinned to 6.2.1 but
`@fortawesome/free-brands-svg-icons` is 7.1.0; update
`@fortawesome/fontawesome-svg-core` to a v7 range (e.g., ^7.0.0 or ^7.1.0) and
align the other FontAwesome packages (e.g., `@fortawesome/free-regular-svg-icons`,
`@fortawesome/free-solid-svg-icons`, `@fortawesome/react-fontawesome`) to compatible
v7 releases so all fontawesome packages use the same major version; after
updating the package.json entry names (e.g.,
"@fortawesome/fontawesome-svg-core": "^7.x"), run your package manager install
to refresh lockfiles and test for runtime/import issues.
1 participant
Hello @Zahnentferner , @varunchitre15 , @heychirag #429
I've updated the Discord invitation link throughout the website to the new, valid one (https://discord.gg/xnmAPS7zqB).
Here are the files I updated:
src/components/Footer.jsx
src/pages/index.jsx
src/pages/apply.jsx
README.md
You can now test the link to ensure it correctly directs users to the AOSSIE Discord server.
Summary by CodeRabbit
New Features
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.