-
Notifications
You must be signed in to change notification settings - Fork 334
fixed the project link not working issue #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fixed the project link not working issue #526
Conversation
|
@Mr-Hariom-Kumar is attempting to deploy a commit to the AOSSIE Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughChanged project card link rendering: the non-clickable paragraph containing the LinkIcon and label is now wrapped in an anchor ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
i hope this will solve the issue 😊 . if any query? let me know first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Fix all issues with AI Agents 🤖
In @src/pages/projects.jsx:
- Around line 86-89: The LinkIcon is placed outside the anchor so only the text
(project.link.label) is clickable; move the LinkIcon into the <a> that uses
project.link.href so both the icon and the label are wrapped by the same anchor
(i.e., wrap LinkIcon and the <span className="ml-2">{project.link.label}</span>
together in the <a>), preserving the existing classes/ARIA and keeping the outer
<p> (or replace with a non-semantic container if needed) so the visual unit is
fully interactive.
- Line 88: Update the anchor that renders external project links so it includes
rel="noopener noreferrer" and move the styling class from the inner span to the
anchor; specifically, replace the pattern <a href={project.link.href}><span
className="ml-2">{project.link.label}</span></a> with an anchor that has
href={project.link.href}, rel="noopener noreferrer" and className="ml-2" and
render {project.link.label} directly (remove the unnecessary span).
Mr-Hariom-Kumar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for misunderstanding i came to realize that the Linkicon is also the part of the url.
now it si perfect, i did a very minor change just wrapped entire p tag in anchor tag.
This PR adds an anchor () tag to redirect users to the projects page.
issue: #524
demo video
issue524soln.mp4
what changes made
just wrapped span tag here in an and done👍

Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.