Skip to content

Conversation

@Mr-Hariom-Kumar
Copy link

@Mr-Hariom-Kumar Mr-Hariom-Kumar commented Jan 5, 2026

This PR adds an anchor () tag to redirect users to the projects page.

issue: #524

demo video

issue524soln.mp4

what changes made

just wrapped span tag here in an and done👍
image

Summary by CodeRabbit

  • Bug Fixes
    • Fixed project links in project cards so the entire card area is clickable and navigates to the intended destination, preserving appearance and improving navigation/usability.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Jan 5, 2026

@Mr-Hariom-Kumar is attempting to deploy a commit to the AOSSIE Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Jan 5, 2026

📝 Walkthrough

Walkthrough

Changed project card link rendering: the non-clickable paragraph containing the LinkIcon and label is now wrapped in an anchor (<a>) with href set to project.link.href and rel="noopener noreferrer", altering the DOM so the block is fully clickable.

Changes

Cohort / File(s) Change Summary
Project Card Link Navigation
src/pages/projects.jsx
Replaced non-clickable paragraph/span containing the link icon and label with an anchor (<a href={project.link.href} rel="noopener noreferrer">) that wraps the same inner content, making the entire block clickable.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A quiet paragraph learned to roam,
Wrapped in an anchor, it finally has a home.
Now clicks take you places with a joyful spring,
Cards come alive — oh what fun they bring! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fixed the project link not working issue' directly addresses the main change in the PR: enabling the project link to function by wrapping it in an anchor tag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d7f2ff and f701a7c.

📒 Files selected for processing (1)
  • src/pages/projects.jsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/projects.jsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Mr-Hariom-Kumar
Copy link
Author

i hope this will solve the issue 😊 . if any query? let me know first

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Fix all issues with AI Agents 🤖
In @src/pages/projects.jsx:
- Around line 86-89: The LinkIcon is placed outside the anchor so only the text
(project.link.label) is clickable; move the LinkIcon into the <a> that uses
project.link.href so both the icon and the label are wrapped by the same anchor
(i.e., wrap LinkIcon and the <span className="ml-2">{project.link.label}</span>
together in the <a>), preserving the existing classes/ARIA and keeping the outer
<p> (or replace with a non-semantic container if needed) so the visual unit is
fully interactive.
- Line 88: Update the anchor that renders external project links so it includes
rel="noopener noreferrer" and move the styling class from the inner span to the
anchor; specifically, replace the pattern <a href={project.link.href}><span
className="ml-2">{project.link.label}</span></a> with an anchor that has
href={project.link.href}, rel="noopener noreferrer" and className="ml-2" and
render {project.link.label} directly (remove the unnecessary span).
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dfb8668 and 1d7f2ff.

📒 Files selected for processing (1)
  • src/pages/projects.jsx

Copy link
Author

@Mr-Hariom-Kumar Mr-Hariom-Kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for misunderstanding i came to realize that the Linkicon is also the part of the url.
now it si perfect, i did a very minor change just wrapped entire p tag in anchor tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant