-
-
Notifications
You must be signed in to change notification settings - Fork 148
Fix backend startup documentation and uvicorn execution path #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -173,11 +173,14 @@ cd app | |||||
| npm run dev | ||||||
| ``` | ||||||
|
|
||||||
| 2. Start the backend server (from the backend/app directory): | ||||||
| 2. Start the backend server (from the Backend directory): | ||||||
| ```sh | ||||||
| uvicorn main:app --reload | ||||||
| cd Backend | ||||||
| uvicorn app.main:app --reload | ||||||
| ``` | ||||||
|
|
||||||
| **Important**: Do not run the server from inside the `app/` directory as this will cause relative import errors. The application must be executed from the project root so that `app` is treated as a proper Python package. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarify "project root" terminology to prevent confusion. The phrase "project root" is ambiguous—it could refer to either the repository root ( 📝 Proposed fix for clearer terminology-**Important**: Do not run the server from inside the `app/` directory as this will cause relative import errors. The application must be executed from the project root so that `app` is treated as a proper Python package.
+**Important**: Do not run the server from inside the `app/` directory as this will cause relative import errors. The application must be executed from the `Backend/` directory (the backend root) so that `app` is treated as a proper Python package.📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| ## Data Population | ||||||
|
|
||||||
| To populate the database with initial data, follow these steps: | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Path navigation will fail if instructions are followed sequentially.
The instruction at line 178
cd Backendwon't work for users following the setup steps in order. By line 178, users are in thebackend/app/directory (from line 130:cd app), socd Backendwill fail with "directory not found."Additionally, there's a case sensitivity inconsistency: line 119 uses lowercase
backendwhile line 178 uses capitalizedBackend. On case-sensitive filesystems (Linux/Mac), these are different directories.🔧 Proposed fix for correct navigation and case consistency
Option 1 (Recommended): Fix the navigation command to go back to the Backend directory:
🤖 Prompt for AI Agents