fix: add safety fallback for EMBEDDING_MAX_BATCH_SIZE parsing #249
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
The PR is : #244
📝 Description
This PR adds robust error handling for the
EMBEDDING_MAX_BATCH_SIZEenvironment variable. Previously, the application would encounter aValueErrorand crash during startup if the environment variable was set to a non-integer string.This change introduces a
try-exceptblock to ensure that if the environment variable is misconfigured, the system gracefully falls back to a default value of32and remains operational.🔧 Changes Made
EMBEDDING_MAX_BATCH_SIZEparsing in atry-exceptblock inbackend/config.py.📷 Screenshots or Visual Changes (if applicable)
N/A: This is a backend logic change for stability.
🤝 Collaboration
✅ Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.