-
Notifications
You must be signed in to change notification settings - Fork 121
docs: fix incorrect Flask path in installation guide #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis pull request corrects the Flask backend startup instructions in the installation guide. The primary change relocates the Flask command to execute from the correct code-graph-backend directory and updates the Flask app path from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/INSTALL_GUIDE.md (1)
254-256: Consider documenting port 5000 in the troubleshooting section.The Flask Code Graph Backend now runs on port 5000 (line 81), but this port isn't mentioned in the "Port conflicts" troubleshooting section. Consider adding it for completeness:
4. **Port conflicts** - Backend runs on port 8000 - Frontend runs on port 5173 (Vite default) - Weaviate runs on port 8080 + - Code Graph Backend (Flask) runs on port 5000
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/INSTALL_GUIDE.md
🔇 Additional comments (2)
docs/INSTALL_GUIDE.md (2)
79-81: Excellent fix for the Flask startup command!The changes correctly address the issue:
- Using
api.index(module reference) instead ofapi/index.py(file path) is the proper Flask syntax- The
cdcommand navigates to the correct nested directory- The helpful note on line 79 will reduce onboarding friction
73-81: Usepoetry runprefix for Flask command for consistency and robustness.Lines 73 and 76 use
poetry run pythonto execute Python scripts. Line 81 runsflaskdirectly without thepoetry runprefix. Sincecode-graph-backendis a separate poetry project (with its ownpyproject.toml), usingpoetry run flaskensures the command executes in the correct environment and maintains consistency with the other commands in the setup instructions.-flask --app api.index run --debug --port 5000 +poetry run flask --app api.index run --debug --port 5000
Closes #229
📝 Description
This pull request fixes an incorrect Flask startup command in the Installation Guide (Quick Start – Step 8).
The documentation previously instructed users to run the Flask app from the
backend/directory, which caused aCould not import 'index'error because the Flask application is nested deeper in the repository. This wasconfusing for new contributors, especially on Windows.
The guide has been updated to reflect the correct working directory and Flask app module path.
🔧 Changes Made
api.indexcode-graph-backenddirectory📷 Screenshots or Visual Changes (if applicable)
Not applicable — documentation-only changes.
🤝 Collaboration
Collaborated with: N/A
✅ Checklist
(Not applicable for documentation changes)
(Not applicable for documentation changes)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.