Skip to content

fix iamf-opus non-48kHz issue #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yilun-zhangs merged 1 commit into from
Mar 26, 2025
Merged

fix iamf-opus non-48kHz issue #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions code/src/iamf_dec/IAMF_decoder.c
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,8 +673,9 @@ static int iamf_codec_conf_get_sampling_rate(IAMF_CodecConf *c) {
if (c->decoder_conf_size < 6) return IAMF_ERR_BAD_ARG;
return reads32be(c->decoder_conf, 2);
} else if (cid == IAMF_CODEC_OPUS) {
if (c->decoder_conf_size < 8) return IAMF_ERR_BAD_ARG;
return reads32be(c->decoder_conf, 4);
// https://aomediacodec.github.io/iamf/v1.1.0.html#opus-specific
// The sample rate used for computing offsets SHALL be 48 kHz.
return 48000;
} else if (cid == IAMF_CODEC_AAC) {
BitStream b;
int ret, type;
Expand Down
2 changes: 1 addition & 1 deletion code/src/iamf_dec/opus/IAMF_opus_decoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ static int iamf_opus_init(IAMF_CodecContext *ths) {
return IAMF_ERR_BAD_ARG;
}

ths->sample_rate = readu32be(config, 4);
ths->sample_rate = 48000; // readu32be(config, 4);
ths->channel_mapping_family = config[10];

ctx->dec = opus_multistream2_decoder_create(ths->sample_rate, ths->streams,
Expand Down