Skip to content

Conversation

@vigneshvg
Copy link
Contributor

This avoids excessive CI runs when pushing changes to other
branches on forks.

This avoids excessive CI runs when pushing changes to other
branches on forks.
@vigneshvg vigneshvg marked this pull request as ready for review July 17, 2024 20:01
@vigneshvg vigneshvg requested review from vrabaud and wantehchang July 17, 2024 20:01
@wantehchang wantehchang requested a review from y-guyon July 17, 2024 20:46
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vignesh: Thanks for the improvement. I am not familiar with the "run on" settings, so I am deferring to Vincent and Yannis.

We need to make sure we run these on release branches. Is there a way to specify that?

We can assume our release branches follow the naming convension v*.*.x.

@y-guyon
Copy link
Contributor

y-guyon commented Jul 18, 2024

I disabled GitHub actions on my fork some time ago to avoid this issue. Local tests and PR tests are enough for me.

We need to make sure we run these on release branches.

I agree. Maybe restricting to base repository branches would be better but that may be difficult to setup.

@vrabaud
Copy link
Contributor

vrabaud commented Jul 18, 2024

I agree, we should keep that for release branches and tags:

branches
  - main
  - 'v*.*.x'
tags
  - v*.*.x

cf https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-branches-and-tags

@vrabaud vrabaud added this to the v1.1.1 milestone Jul 25, 2024
@wantehchang wantehchang removed this from the v1.1.1 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants