deps: Update ancplua-sdk to 3.4.36#149
Merged
Merged
Conversation
ANcpLua.NET.Sdk 3.4.35 → 3.4.36 Carries help-links fix (f052561, dead mintlify URL replaced) and AL pin bump 2.0.0 → 2.0.1 with regenerated editorconfig. Leaves ANcpLuaAnalyzersVersion=1.29.4 untouched — dual-ID editorconfig (212210f) handles both 1.29.x and 2.0.x rules during the AL transition. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@coderabbitai autofix |
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
The pull request successfully updates the ANcpLua.NET.Sdk versions in global.json from 3.4.35 to 3.4.36 while correctly maintaining the analyzer version as intended. Codacy analysis indicates that the changes are up to standards, with no new issues or complexity increases. There are no critical blockers preventing this merge.
Test suggestions
- Verify that all referenced ANcpLua SDKs in global.json are synchronized to version 3.4.36
- Run generator snapshot tests to ensure compatibility with the updated SDK version
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that all referenced ANcpLua SDKs in global.json are synchronized to version 3.4.36
2. Run generator snapshot tests to ensure compatibility with the updated SDK version
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ANcpLua.NET.Sdkfamily (*,*.Web,*.Test) from 3.4.35 → 3.4.36ANcpLuaAnalyzersVersion=1.29.4untouched per dual-ID transitional designWhat's in SDK 3.4.36
On the AL pin
This bump intentionally does not touch
ANcpLuaAnalyzersVersion=1.29.4. The dual-ID editorconfig overrides from 212210f cover bothAL0xxx(1.29.x) andAL1xxx(2.0.x) rule IDs, allowing the SDK's self-injected v2.0.1 analyzer to coexist with the project's pinned 1.29.4 reference during the transition. Flipping the explicit pin to 2.0.x is a separate decision and should be its own PR.Test plan
🤖 Generated with Claude Code