deps: Update ancplua-sdk to 3.4.35#176
Conversation
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the ANcpLua.NET SDK, Sdk.Web, and Sdk.Test versions to 3.4.35 within the global.json configuration. The update incorporates CI improvements and an AL analyzer version bump. The changes are compliant with quality standards, and no high-risk files or critical vulnerabilities were identified.
Test suggestions
- Verify that the project build completes successfully using the new SDK version 3.4.35
- Verify that the updated AL analyzer (v2.0.0) bundled with the SDK does not introduce unexpected compilation errors
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the project build completes successfully using the new SDK version 3.4.35
2. Verify that the updated AL analyzer (v2.0.0) bundled with the SDK does not introduce unexpected compilation errors
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Post-publish follow-up. AL 2.0.0 was indexed on nuget.org 2026-05-25; the LAST-PUBLISHED self-reference can now track the new major. Why this is needed RIGHT NOW: Renovate's auto-bump PR for ancplua-sdk 3.4.34 → 3.4.35 (#176) failed `build` with errors like error AL0101: Activator.CreateInstance<T>() ... error AL0039: Use 'identifier.ContainsOrdinal(_)' ... Those are PRE-renumber rule IDs (renumbered to AL1408 / AL1210 in 2.0.0). They fired because AL's OWN restore resolved the analyzer at the local Version.props pin (1.29.4) instead of the SDK-pinned 2.0.0 — Version.props overrides SDK.Common.Version.props. Bumping the pin to 2.0.0 makes the dogfood analyzer the same as the bundled-in-SDK analyzer (AL1xxx IDs), which the AL source already aligns with (the renumber commit fcc2a2b moved every NoWarn / suppression to new IDs). After this lands, retrigger #176 (rebase) — build should pass. Also extended the invariant comment to capture the post-publish rule: "after publishing N.M.P, bump to N.M.P; never set to N.M.P+1 before that publish lands." Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
renovate
Bot
force-pushed
the
renovate/ancplua-sdk
branch
from
edcb6c3 to
18e23be
Compare
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
1 participant
This PR contains the following updates:
3.4.34→3.4.353.4.34→3.4.353.4.34→3.4.35Release Notes
ANcpLua/ANcpLua.NET.Sdk (ANcpLua.NET.Sdk)
v3.4.35What's Changed
f28e40cby @renovate[bot] in #1752449274by @renovate[bot] in #178787c5a0by @renovate[bot] in #179Full Changelog: ANcpLua/ANcpLua.NET.Sdk@v3.4.34...v3.4.35
Configuration
📅 Schedule: (in timezone UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.