squeeze some more space out of VODE's memory footprint#1867
Draft
zingale wants to merge 14 commits intoAMReX-Astro:developmentfrom
Draft
squeeze some more space out of VODE's memory footprint#1867zingale wants to merge 14 commits intoAMReX-Astro:developmentfrom
zingale wants to merge 14 commits intoAMReX-Astro:developmentfrom
Conversation
Member
Author
Member
Author
|
this actually results in a 1% slowdown on Frontier (for |
Member
Author
|
groot GPU tests: http://groot.astro.sunysb.edu/Microphysics/test-suite/gpu/2025-10-25-001/index.html it seems like this can make a small diff in some cases with CUDA. On Frontier, it is less clear. |
Member
Author
|
changing the type of the pivot array makes things worse. If I remove that, the remainder of the changes are mostly just making things const. |
Member
Author
|
this still causes answer diffs on Frontier. Not sure where the issue is |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.