[WIP] allow for an alternate EOS table for the helmholtz EOS#1846
Open
zingale wants to merge 21 commits intoAMReX-Astro:developmentfrom
Open
[WIP] allow for an alternate EOS table for the helmholtz EOS#1846zingale wants to merge 21 commits intoAMReX-Astro:developmentfrom
zingale wants to merge 21 commits intoAMReX-Astro:developmentfrom
Conversation
Member
Author
|
Here's a comparison of |
Member
Author
Member
Author
|
This has been updated now to use approximate functions for log and pow, and seems to get better performance. It needs more testing, in particular, the comparison of test_eos shows large-ish errors for |
Member
Author
|
just tested this again on Perlmutter / CUDA, and the alternate EOS table is no faster. The logs we are doing for indexing into the table are not the rate-limiting step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This will allow for a table generated by our new C++ EOS, which uses better quadrature and precision and should be more accurate overall for the electron-positron component.