pldm: Add Numeric Effecters by spargaon · Pull Request #50 · AMDESE/pldm

spargaon · 2026-01-30T18:40:53Z

Add Numeric Effecter PDR for Compact Numeric Sensors. Numeric Effecter and Effecter Auxiliary Name PDRs are are represented using JSON files.
Numeric Effecter PDR act as a control for Compact
Numeric Sensor PDR matched by effecter id.

spargaon · 2026-01-30T19:21:02Z

fwdev-170035.log.txt
fwdev-170035.test.txt

spargaon · 2026-02-04T06:40:47Z

fwdev-170035.log.2.txt

spargaon · 2026-02-04T07:06:36Z

fwdev-170035.test.3.txt

spargaon · 2026-02-04T20:18:53Z

fwdev-170035.test.set-property-get-property.txt

Verified on one of the numeric effecters that get-propety and set-property work.

mahkurap · 2026-02-20T16:36:35Z

        std::chrono::seconds(DBUS_TIMEOUT))
        .count();

+extern "C" {


Please move this code to libpldm, and also add encode/decode routines for effecter enable command.

spargaon · 2026-03-10T18:01:33Z

FWDEV-170035.031026.1.log
FWDEV-170035.031026.1.test.txt

Add Numeric Effecter PDR for Compact Numeric Sensors. Numeric Effecter and Effecter Auxiliary Name PDRs are are represented using JSON files. Numeric Effecter PDR act as a control for Compact Numeric Sensor PDR matched by effecter id. This code is ported code ushered in via commit id c8bcfa8 which is still being reviewed. Minor tweaks were applied to port this patch. === platform-mc: Add NumericEffecter support as per DSP0248 Implement PDR-driven NumericEffecter class that follows the PLDM Platform Monitoring and Control specification, addressing limitations in the existing dbus_to_terminus_effecters approach. Features: - Discovery: Parse Numeric Effecter PDRs (§28.11) from device and create D-Bus object - Following commands are supported: - GetNumericEffecterValue (0x32), - SetNumericEffecterEnable (0x30), - SetNumericEffecterValue (0x31) - Bidirectional state sync: D-Bus reflects actual terminus state via read-after-write verification - NumericEffecterDbusInterface: Abstract interface to enable D-Bus integration for numeric effecters Tested. This patch was tested on Nvidia's GB200 Platform for Grace CPU Terminus. Redfish Testing is still pending. Pick the following bmcweb patch: https://gerrit.openbmc.org/c/openbmc/bmcweb/+/86196 === Signed-off-by: Shirish Pargaonkar <Shirish.Pargaonkar@amd.com> # modified: ../../../../platform-mc/test/terminus_manager_test.cpp

spargaon requested review from aasboddu, mahkurap, srgovard and supven01 January 30, 2026 18:40

spargaon force-pushed the fwdevel-170035-review branch from cfb5ec1 to 9fa71b3 Compare January 30, 2026 19:44

spargaon force-pushed the fwdevel-170035-review branch from 9fa71b3 to d028ba9 Compare February 4, 2026 06:56

mahkurap reviewed Feb 20, 2026

View reviewed changes

Comment thread common/types.hpp Outdated

mahkurap requested changes Feb 20, 2026

View reviewed changes

spargaon force-pushed the fwdevel-170035-review branch 3 times, most recently from d300bd6 to 34f64b1 Compare March 10, 2026 17:55

spargaon force-pushed the fwdevel-170035-review branch 2 times, most recently from 852d5c3 to 727e0ab Compare March 11, 2026 05:10

spargaon requested a review from mahkurap March 11, 2026 05:28