Skip to content

arm64:dts: Add SP8 PRB VR FS1606#268

Open
modolaty wants to merge 1 commit into
integ_sp8from
v081a_sp8PRB
Open

arm64:dts: Add SP8 PRB VR FS1606#268
modolaty wants to merge 1 commit into
integ_sp8from
v081a_sp8PRB

Conversation

@modolaty
Copy link
Copy Markdown
Collaborator

Add new System VR FS1606 for SP8 PRBs Falcon and Seagull

Tested:

  • verified in Falcon and Seagull

Add new System VR FS1606 for SP8 PRBs Falcon and Seagull

Tested:
- verified in Falcon and Seagull

Signed-off-by: modolaty <mohsen.dolaty@amd.com>
Copy link
Copy Markdown

@anshaw9 anshaw9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

Just one small suggestion:

  • We can combine the compatible entries into a single line:
    compatible = "tdk,fs1606a", "pmbus";

  • Also, for consistency, we may prefer lowercase hex formatting for addresses:
    reg = <0x09>;
    reg = <0x0a>;

Suggested format:

p1v8aux@09 {
// P1V8_AUX VRM
// TDK: FS1606
compatible = "tdk,fs1606a", "pmbus";
reg = <0x09>;
};

p0v85aux@0a {
// P0V85_AUX VRM
// TDK: FS1606
compatible = "tdk,fs1606a", "pmbus";
reg = <0x0a>;
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants