fix: respect @param docblock overrides#55
Merged
AJenbo merged 1 commit intoAJenbo:mainfrom Mar 31, 2026
Merged
Conversation
AJenbo
force-pushed
the
calebdw/push-tpwruoztqtkz
branch
from
ff24f62 to
947e922
Compare
When a method parameter has both a native type hint (e.g. Node) and a @param docblock override (e.g. @param FuncCall $node), use resolve_effective_type() to pick the more specific type before attempting class resolution. Previously the native hint was resolved first and the docblock was only checked as a fallback when the native hint didn't resolve to a class, which meant @param overrides on resolvable types were silently ignored. Fixes AJenbo#49
AJenbo
force-pushed
the
calebdw/push-tpwruoztqtkz
branch
from
947e922 to
f88fd8d
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (72.94%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
- Coverage 87.81% 87.78% -0.03%
==========================================
Files 144 144
Lines 82847 82890 +43
==========================================
+ Hits 72749 72762 +13
- Misses 10098 10128 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This closes #49, same thing, just had AI take a crack at it so feel free to make changes
Thanks!