feat: move colocated-python-sidecar to worker job in pathways template#1182
Open
ChromeHearts wants to merge 1 commit into
Open
feat: move colocated-python-sidecar to worker job in pathways template#1182ChromeHearts wants to merge 1 commit into
ChromeHearts wants to merge 1 commit into
Conversation
ChromeHearts
requested review from
FIoannides,
SikaGrr,
jamOne-,
scaliby and
stony-tark
as code owners
ChromeHearts
force-pushed
the
dnlng/move-sidecar-to-worker
branch
from
6cfb24f to
6973845
Compare
Member
|
@ChromeHearts please update goldens. |
This change moves the colocated-python-sidecar from the pathways-head job to the worker job as an initContainer. It also updates the sidecar configuration with necessary environment variables for gRPC, unbuffered logging, and high-verbosity debug logs.
ChromeHearts
force-pushed
the
dnlng/move-sidecar-to-worker
branch
from
6973845 to
d0d0203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported in b/b/507543259.
This change moves the colocated-python-sidecar from the pathways-head job to the worker job as an initContainer. It also updates the sidecar configuration with necessary environment variables for gRPC, unbuffered logging, and high-verbosity debug logs.
Description
Change the Pathways workload creation template.
Issue
when --colocated-python-sidecar-image is set, the created jobset is incorrect.
Testing
In this PR, I am able to run colocated-python job successfully.