[slice] Extend e2e test for cube failure #1003
Merged
+61
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajakd
changed the title
PBundyra
reviewed
Jan 21, 2026
| }) | ||
|
|
||
| ginkgo.By("Checking that a new Slice is created", func() { | ||
| ginkgo.By(fmt.Sprintf("Setting the old cube %s to unhealthy", oldCube), func() { |
Collaborator
There was a problem hiding this comment.
I think this should be done before the SliceState is set to error
Collaborator
Author
There was a problem hiding this comment.
Both should work, but you are right, this looks more realistic. Updated.
PBundyra
reviewed
Jan 21, 2026
| }, utils.Timeout, utils.Interval).Should(gomega.Succeed()) | ||
| }, nodeName) | ||
| }) | ||
|
|
Collaborator
There was a problem hiding this comment.
Could we verify that Workload's status.schedulingStats contain the eviction?
Collaborator
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to validate that after cube failure, the re-created slice includes only healthy cubes.
Issue
Testing