Conditionally branch tokamax.ragged_dot calls based on use_manual_quantization#3869
Open
zxhe-sean wants to merge 1 commit into
Open
Conditionally branch tokamax.ragged_dot calls based on use_manual_quantization#3869zxhe-sean wants to merge 1 commit into
zxhe-sean wants to merge 1 commit into
Conversation
…uantization to avoid passing None to manual_axis_type
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Conditionally branch tokamax.ragged_dot calls based on use_manual_quantization to avoid passing None to manual_axis_type
The ubench nightly tests broke due to
TypeError: ragged_dot() got an unexpected keyword argument 'manual_axis_type'FIXES: b/511266446
Tests
Tested locally with AOT compiling and successfully compiled.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.