Skip to content

Conditionally branch tokamax.ragged_dot calls based on use_manual_quantization#3869

Open
zxhe-sean wants to merge 1 commit into
mainfrom
zxhe/tokamax_ragged_dot
Open

Conditionally branch tokamax.ragged_dot calls based on use_manual_quantization#3869
zxhe-sean wants to merge 1 commit into
mainfrom
zxhe/tokamax_ragged_dot

Conversation

@zxhe-sean
Copy link
Copy Markdown
Collaborator

Description

Conditionally branch tokamax.ragged_dot calls based on use_manual_quantization to avoid passing None to manual_axis_type

The ubench nightly tests broke due to TypeError: ragged_dot() got an unexpected keyword argument 'manual_axis_type'

FIXES: b/511266446

Tests

Tested locally with AOT compiling and successfully compiled.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

…uantization to avoid passing None to manual_axis_type
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/kernels/megablox/ops.py 0.00% 9 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant