Enable Qwen3-Omni SFT on ChartQA#3863
Draft
hengtaoguo wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
768 x 768resize resolution inpreprocess_mm_data_qwen3_omni_for_trainingto guarantee identical patch counts and uniform tensor shapes across diverse batch examples, fully resolvinggrain.Batchstacking mismatches.patch_size_for_vit = 16and reshapes flattened patch arrays back to unflattened 5D tensors(batch, channels, temporal, height, width), eliminatingValueError: not enough values to unpackat the vision encoder input.single_image_offsetcalculation ininput_pipeline_utils.pyto safely use thenum_imagesattribute, preventingZeroDivisionErrorcrashes on flattened patch counts. Adds an explicit padding bypass for Qwen3 Omni patch tensors to avoid false mask limit exceptions.Tests
10-step E2E test run:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.