Simplify maybe_initialize_jax_distributed_system()#3847
Open
SurbhiJainUSC wants to merge 1 commit into
Open
Conversation
1c67351 to
f1ed8f4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dccb7dd to
a31c6c1
Compare
a31c6c1 to
83731d1
Compare
gobbleturk
reviewed
May 11, 2026
| self.assertEqual(padding_amount, target_padding_amount) | ||
|
|
||
|
|
||
| class TestMaybeInitializeJaxDistributedSystem(unittest.TestCase): |
Collaborator
There was a problem hiding this comment.
there may be weird interactions with pytest, - it looks like this is heavily mocked, so jax.distributed.initialize is never really called? Could you include a comment if this is the case. If you don't mock I am not sure this will work
gobbleturk
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the JAX distributed initialization process by simplifying the
maybe_initialize_jax_distributed_system()function.Tests
CI tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.