Fix: Upload docker images on pypi release#3487
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bvandermoon
approved these changes
Mar 23, 2026
511bb10 to
6ae8475
Compare
igorts-git
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
MaxText 0.2.1was released by triggeringpypi_release.ymlworflow in Github, it didn't upload the docker images to GCR. The reason beingpyipi_release.ymlworkflow is triggered byon: release. However,build_and_push_Docker_images.ymlworkflow has a conditional check that allows job to run only for "schedule", "pull_request", or "workflow_dispatch". Since release is not listed in that if: condition, the job evaluates to false and skips immediately: https://github.com/AI-Hypercomputer/maxtext/actions/runs/23462478704/job/68272569186Tests
https://github.com/AI-Hypercomputer/maxtext/actions/runs/23502503748
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.