Skip to content

Fix: Upload docker images on pypi release#3487

Merged
copybara-service[bot] merged 1 commit intomainfrom
pypi_docker_fix
Mar 24, 2026
Merged

Fix: Upload docker images on pypi release#3487
copybara-service[bot] merged 1 commit intomainfrom
pypi_docker_fix

Conversation

@SurbhiJainUSC
Copy link
Collaborator

@SurbhiJainUSC SurbhiJainUSC commented Mar 23, 2026

Description

When MaxText 0.2.1 was released by triggering pypi_release.yml worflow in Github, it didn't upload the docker images to GCR. The reason being pyipi_release.yml workflow is triggered by on: release. However, build_and_push_Docker_images.yml workflow has a conditional check that allows job to run only for "schedule", "pull_request", or "workflow_dispatch". Since release is not listed in that if: condition, the job evaluates to false and skips immediately: https://github.com/AI-Hypercomputer/maxtext/actions/runs/23462478704/job/68272569186

Tests

https://github.com/AI-Hypercomputer/maxtext/actions/runs/23502503748

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@copybara-service copybara-service bot merged commit 263bd9d into main Mar 24, 2026
44 checks passed
@copybara-service copybara-service bot deleted the pypi_docker_fix branch March 24, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants