Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
This PR successfully fixes the parameter mapping for Qwen2 models by restoring support for qwen2.5-7b and qwen2.5-14b. It also introduces necessary Q/K/V bias hooks and cleanly renames the internal mapping functions to be more general (QWEN_ instead of QWEN3_).
🔍 General Feedback
- The addition of
reshape_biasperfectly complements the new bias hooks for Qwen attention layers. - Consider removing the redundant conditional in the
reshape_biasfunction to keep the code DRY, as the underlyingreshapeoperation inherently handles both directions correctly.
31d2f5c to
19b0ea1
Compare
19b0ea1 to
c6679fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests
end2end test for qwen2.5-7b
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.