Skip to content

let tunix see lr hyperparams for logging#3444

Open
andytwigg wants to merge 1 commit intomainfrom
atwigg/log_lr_hparam
Open

let tunix see lr hyperparams for logging#3444
andytwigg wants to merge 1 commit intomainfrom
atwigg/log_lr_hparam

Conversation

@andytwigg
Copy link
Collaborator

Description

use optax hyperparam inject wrapper to let tunix see lr hyperparams for logging

Tests

ran and observed that tunix was logging LR correctly.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/trainers/post_train/rl/utils_rl.py 44.44% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@A9isha A9isha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy!

Copy link
Collaborator

@richjames0 richjames0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andytwigg andytwigg force-pushed the atwigg/log_lr_hparam branch from 2b1b592 to 19eebe9 Compare March 24, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants