-
Notifications
You must be signed in to change notification settings - Fork 56
[Feature] Add LoRA Inference Support for WAN Models via Flax NNX #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Perseus14
wants to merge
1
commit into
main
Choose a base branch
from
wan_lora
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """NNX-based LoRA loader for WAN models.""" | ||
|
|
||
| from flax import nnx | ||
| from .lora_base import LoRABaseMixin | ||
| from .lora_pipeline import StableDiffusionLoraLoaderMixin | ||
| from ..models import lora_nnx | ||
| from .. import max_logging | ||
| from . import lora_conversion_utils | ||
|
|
||
|
|
||
| class Wan2_1NnxLoraLoader(LoRABaseMixin): | ||
| """ | ||
| Handles loading LoRA weights into NNX-based WAN 2.1 model. | ||
| Assumes WAN pipeline contains 'transformer' | ||
| attributes that are NNX Modules. | ||
| """ | ||
|
|
||
| def load_lora_weights( | ||
| self, | ||
| pipeline: nnx.Module, | ||
| lora_model_path: str, | ||
| transformer_weight_name: str, | ||
| rank: int, | ||
| scale: float = 1.0, | ||
| scan_layers: bool = False, | ||
| **kwargs, | ||
| ): | ||
| """ | ||
| Merges LoRA weights into the pipeline from a checkpoint. | ||
| """ | ||
| lora_loader = StableDiffusionLoraLoaderMixin() | ||
|
|
||
| merge_fn = lora_nnx.merge_lora_for_scanned if scan_layers else lora_nnx.merge_lora | ||
|
|
||
| def translate_fn(nnx_path_str): | ||
| return lora_conversion_utils.translate_wan_nnx_path_to_diffusers_lora(nnx_path_str, scan_layers=scan_layers) | ||
|
|
||
| # Handle high noise model | ||
| if hasattr(pipeline, "transformer") and transformer_weight_name: | ||
| max_logging.log(f"Merging LoRA into transformer with rank={rank}") | ||
| h_state_dict, _ = lora_loader.lora_state_dict(lora_model_path, weight_name=transformer_weight_name, **kwargs) | ||
| merge_fn(pipeline.transformer, h_state_dict, rank, scale, translate_fn) | ||
| else: | ||
| max_logging.log("transformer not found or no weight name provided for LoRA.") | ||
|
|
||
| return pipeline | ||
|
|
||
|
|
||
| class Wan2_2NnxLoraLoader(LoRABaseMixin): | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit - make NNX all upper case. |
||
| """ | ||
| Handles loading LoRA weights into NNX-based WAN 2.2 model. | ||
| Assumes WAN pipeline contains 'high_noise_transformer' and 'low_noise_transformer' | ||
| attributes that are NNX Modules. | ||
| """ | ||
|
|
||
| def load_lora_weights( | ||
| self, | ||
| pipeline: nnx.Module, | ||
| lora_model_path: str, | ||
| high_noise_weight_name: str, | ||
| low_noise_weight_name: str, | ||
| rank: int, | ||
| scale: float = 1.0, | ||
| scan_layers: bool = False, | ||
| **kwargs, | ||
| ): | ||
| """ | ||
| Merges LoRA weights into the pipeline from a checkpoint. | ||
| """ | ||
| lora_loader = StableDiffusionLoraLoaderMixin() | ||
|
|
||
| merge_fn = lora_nnx.merge_lora_for_scanned if scan_layers else lora_nnx.merge_lora | ||
|
|
||
| def translate_fn(nnx_path_str: str): | ||
| return lora_conversion_utils.translate_wan_nnx_path_to_diffusers_lora(nnx_path_str, scan_layers=scan_layers) | ||
|
|
||
| # Handle high noise model | ||
| if hasattr(pipeline, "high_noise_transformer") and high_noise_weight_name: | ||
| max_logging.log(f"Merging LoRA into high_noise_transformer with rank={rank}") | ||
| h_state_dict, _ = lora_loader.lora_state_dict(lora_model_path, weight_name=high_noise_weight_name, **kwargs) | ||
| merge_fn(pipeline.high_noise_transformer, h_state_dict, rank, scale, translate_fn) | ||
| else: | ||
| max_logging.log("high_noise_transformer not found or no weight name provided for LoRA.") | ||
|
|
||
| # Handle low noise model | ||
| if hasattr(pipeline, "low_noise_transformer") and low_noise_weight_name: | ||
| max_logging.log(f"Merging LoRA into low_noise_transformer with rank={rank}") | ||
| l_state_dict, _ = lora_loader.lora_state_dict(lora_model_path, weight_name=low_noise_weight_name, **kwargs) | ||
| merge_fn(pipeline.low_noise_transformer, l_state_dict, rank, scale, translate_fn) | ||
| else: | ||
| max_logging.log("low_noise_transformer not found or no weight name provided for LoRA.") | ||
|
|
||
| return pipeline | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - make NNX all upper case.