docs(qemu): clarify post_exec runs after harness completion#3671
Closed
Tanmay140906 wants to merge 6 commits intoAFLplusplus:mainfrom
Closed
docs(qemu): clarify post_exec runs after harness completion#3671Tanmay140906 wants to merge 6 commits intoAFLplusplus:mainfrom
Tanmay140906 wants to merge 6 commits intoAFLplusplus:mainfrom
Conversation
Contributor
Author
|
CI failure appears unrelated to this change. |
Contributor
Author
|
@rmalmain , could you please review this PR and guide me for GSoC 2026? I am trying to make contributions to LibAFL for being selected in GSoC and I need some guidance and answers to few of my questions. Could you please help me? |
Member
|
there's no guarantee that we are participating in GSoC 2026. |
Contributor
Author
|
Okay |
domenukk
reviewed
Feb 6, 2026
| qemu.write_phys_mem(input_addr, buf); | ||
|
|
||
| // `qemu().run()` completes the full harness execution cycle. | ||
| // The snapshot is restored before this call returns. |
Member
|
I don't think we need to really nudge the user to anything here (unless @rmalmain disagrees) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR clarifies the execution timing of
EmulatorHooks::post_exec, documentingthat it runs after the harness completes and after snapshot restoration.
It also adds a small lifecycle note in the qemu_baremetal low-level example to
make it explicit that
qemu().run()completes the full harness execution cycle.This resolves the confusion described in #2765 regarding guest memory reads in
post_exec.Checklist
./scripts/precommit.shand addressed all comments