really fixes google translate issue #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix an issue where Google Translate interferes with text node updates in the virtual DOM. Key changes include:
- Adding an extra parameter (oldChildren) to the updateDom function.
- Updating updateDom calls in updateChildren and createProjection to pass the new parameter.
- Introducing a try-catch block in updateDom to handle errors during text node replacement.
| if (vnode.text !== previous.text) { | ||
| let newTextNode = domNode.ownerDocument!.createTextNode(vnode.text!); | ||
| parentNode.replaceChild(newTextNode, domNode); | ||
| try { |
There was a problem hiding this comment.
In the catch block, 'oldChildren.indexOf(previous)' may return -1 if 'previous' is not found. Consider adding a check to ensure the index is valid before using it to index parentNode.childNodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.