Add routeAddrType filter to path-finding API#3307
Open
rorp wants to merge 2 commits intoACINQ:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
routeAddrTypeparameter tofindroute*,pay*andsendtotnodeAPI calls. It allows to filter the nodes during path finding by their address types.Possible filter values
clearnethybridtorrouteAddrTypeis not specifiedThe rationale for this PR is that empirically Tor-only nodes tend to be unreliable. Excluding them from path finding could improve payment success rate. On the other hand filtering out clearnet nodes could increase payment privacy.
Note that this filter apllies only to intermediary nodes, source and destination nodes are unaffected.